Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FC-0068 docs: how-to cleaning by edunext #14 #758

Merged
merged 17 commits into from
Jan 14, 2025
Merged

FC-0068 docs: how-to cleaning by edunext #14 #758

merged 17 commits into from
Jan 14, 2025

Conversation

BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Jan 8, 2025 •
edited
Loading

This PR modifies a series of how-to documents migrated from the legacy repositories to the educators' documentation.

The updated files were:

  • create_image_mapped_input.rst
  • adding_math_expresion_problems.rst
  • add_multiselect_partial_credit.rst
  • enable_notes.rst
  • edit_numerical_input_advanced.rst
  • add_checkbox.rst
  • enable_lti_component.rst. This file was divided and the following files were created:
    • setting_up_lti_1_1_component.rst
    • setting_up_lti_1_3_component.rst
    • using_lti_advantage_features.rst
  • adding_multi_select.rst. This file was divided and the following file was created:
    • editing_multi_select_using_advanced_editor.rst
  • award_partial_credit_numerical_input.rst. This file was divided and the following file was created:
    • adding_text_in_numeric_response_field.rst

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 8, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 8, 2025 •
edited
Loading

Thanks for the pull request, @BryanttV!

This repository is currently maintained by @openedx/docs-openedx-org-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

sarina
sarina requested changes Jan 9, 2025
View reviewed changes
source/educators/how-tos/course_development/exercise_tools/add_multi_select_partial_credit.rst Outdated Show resolved Hide resolved
source/educators/how-tos/course_development/exercise_tools/adding_math_expression_problem.rst Outdated Show resolved Hide resolved
source/educators/how-tos/course_development/exercise_tools/adding_multi_select.rst Outdated Show resolved Hide resolved
...ducators/how-tos/course_development/exercise_tools/adding_text_in_numeric_response_field.rst Outdated Show resolved Hide resolved
...educators/how-tos/course_development/exercise_tools/award_partial_credit_numerical_input.rst Outdated Show resolved Hide resolved
...ors/how-tos/course_development/exercise_tools/editing_multi_select_using_advanced_editor.rst Outdated Show resolved Hide resolved
source/educators/how-tos/course_development/exercise_tools/enable_lti_component.rst Outdated Show resolved Hide resolved
source/educators/how-tos/course_development/exercise_tools/enable_notes.rst Outdated Show resolved Hide resolved
source/educators/how-tos/course_development/exercise_tools/setting_up_lti_1_1_component.rst Outdated Show resolved Hide resolved
source/educators/how-tos/course_development/exercise_tools/using_lti_advantage_features.rst Outdated Show resolved Hide resolved
@BryanttV BryanttV force-pushed the bav/educators_documentation_review_edunext_15 branch from b232803 to fbb67b4 Compare January 9, 2025 19:06
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jan 13, 2025
sarina
sarina approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix conflicts in your PR and tag me for merge?

BryanttV added 15 commits January 14, 2025 10:16
@BryanttV
docs: update 'create_image_mapped_input.rst' file
1529e2e
@BryanttV
docs: update 'enable_lti_component.rst' file
9eca025
@BryanttV
docs: update 'adding_math_expresion_problems.rst' file
7305821
@BryanttV
docs: update 'add_multiselect_partial_credit.rst' file
7e155d6
@BryanttV
docs: update 'enable_notes.rst' file
975d6a6
@BryanttV
docs: update 'edit_numerical_input_advanced.rst' file
53d92c2
@BryanttV
docs: remove note to edx in 'enable_notes.rst' file
111aa19
@BryanttV
docs: update 'add_checkbox.rst' file
a9adf93
@BryanttV
docs: update and split 'adding_multi_select.rst' file
7cd8679
@BryanttV
docs: update and split 'award_partial_credit_numerical_input.rst' file
2955862
@BryanttV
fix: replace '.' by '_' in the file names
74268a5
@BryanttV
fix: remove blank space in the filename
13bcc82
@BryanttV
docs: replace adding by add in tags
8503399
@BryanttV
fix(docs): adjust titles for consistency with 'How To' phrasing
00eb067
@BryanttV
fix(docs): add missing tag and update :ref: command
a6d4d25
@BryanttV BryanttV force-pushed the bav/educators_documentation_review_edunext_15 branch from cfff858 to a6d4d25 Compare January 14, 2025 15:19
@BryanttV BryanttV force-pushed the bav/educators_documentation_review_edunext_15 branch from 1d43826 to 690a296 Compare January 14, 2025 15:23
@BryanttV
Copy link
Contributor Author

Thanks, @sarina. I resolved the conflicts. The PR is ready to merge.

@sarina sarina merged commit 86caf0a into openedx:main Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarina sarina sarina approved these changes

@Apgomeznext Apgomeznext Awaiting requested review from Apgomeznext

Assignees
No one assigned
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BryanttV @openedx-webhooks @sarina @mphilbrick211